Adding restart reason #11191
Open
Adding restart reason #11191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request adds restart reason logging to provide better troubleshooting context when host restarts occur. The change modifies the RestartHostAsync method across the codebase to accept a reason parameter that gets logged and included in restart events.
- Adds a required
reasonparameter toIScriptHostManager.RestartHostAsyncmethod - Updates all calls to
RestartHostAsyncthroughout the codebase to include descriptive restart reasons - Modifies
HostRestartEventto include the restart reason and updates related logging
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/WebJobs.Script/Host/IScriptHostManager.cs | Adds reason parameter to RestartHostAsync interface method |
| src/WebJobs.Script/Eventing/Host/HostRestartEvent.cs | Adds Reason property to HostRestartEvent class |
| src/WebJobs.Script.WebHost/WebJobsScriptHostService.cs | Implements reason parameter and logs restart reason |
| src/WebJobs.Script.WebHost/Diagnostics/Extensions/ScriptHostServiceLoggerExtension.cs | Updates logging extension to include restart reason |
| src/WebJobs.Script.WebHost/FileMonitoringService.cs | Updates file monitoring restart calls with descriptive reasons |
| src/WebJobs.Script.WebHost/Controllers/HostController.cs | Adds restart reasons for API-triggered restarts |
| Multiple test files | Updates test mocks and verifications to include reason parameter |
| release_notes.md | Documents the new feature |
Copilot suggestion. Co-authored-by: Copilot <[email protected]>
Copilot suggestion. Co-authored-by: Copilot <[email protected]>
Copilot suggestion. Co-authored-by: Copilot <[email protected]>
Copilot suggestion. Co-authored-by: Copilot <[email protected]>
Fixing format.
…re-functions-host into fabiocav/restartreason
mathewc
reviewed
Aug 6, 2025
mathewc
reviewed
Aug 6, 2025
mathewc
reviewed
Aug 6, 2025
mathewc
reviewed
Aug 6, 2025
mathewc
reviewed
Aug 6, 2025
fabiocav
approved these changes
Aug 11, 2025
mathewc
approved these changes
Aug 11, 2025
brettsam
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including the restart reason in the logs will provide valuable context during troubleshooting and root cause analysis.
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not requiredrelease_notes.mdAdditional information
Additional PR information